Repository navigation
ci(bot): enable distillation and cross-review - #575
Conversation
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
There was a problem hiding this comment.
🔀 Cross-reviewed: two independent reviews (Claude Opus 5.5 · GPT-6.1 Terra), checked by a judge model (Claude Sonnet 5.5).
Verdict: 1 Nit
Looks good, no blocking issues. The reviewer workflow now checks out trusted code at the base SHA, and the PR head is checked out separately after an open, same-repo PR check. The archive, lessons and .gitignore routing all look consistent. Follow-up: review-content is a shallow checkout, so confirm the pinned engine doesn't need PR_BASE_SHA history inside it.
This overview is Claude Opus 5.5's initial take; some of its points were set aside by the cross-check judge — see the findings below.
Other findings
- ⚪ Nit — L-0059 claims 4× occurrences but cites only
log:2026-10-21. The matching archive entries from 2026-10-22, 2026-10-30 and 2026-11-12 aren't listed, so the count can't be traced. Add those log dates as sources. (Found by Claude Opus 5.5 · confirmed by the judge)
🔀 1 finding considered and dismissed by the judge
- 🟡 Medium
.github/workflows/reviewer-bot.yml:64— For manual dispatches,github.shais the selected dispatch ref, so choosing a PR branch loads its local prelude with App credentials instead of trusted defaul
Judge's evidence:ref: ${{ github.event.pull_request.base.sha || github.sha }}
|
Keeping the supported source format for L-0059: the engine grammar allows one |
Apply kernel #476's onboarding: enable distill mode with learning-PR auto-merge off, and pin the bot engine to 6014478 for two independent reviewers plus a judge. Manual reviews use trusted workflow code and a separate resolved PR checkout.
Preserve all 84 rules from #443 at 82969ff as a frozen archive and seed 59 lessons. New learning uses dated journal files and a fresh rolling branch. Unignore lessons and journal Markdown so learning commits can track them.
98 focused engine tests passed. Config, archive preservation, lesson routing/source checks, seven reviewer-input cases, Bash syntax and actionlint passed. Live cross-review approved the current head; source-format nit explained.
After merge, run learning once and inspect its first journal/lessons PR. Check #443 for newer entries before retiring that legacy PR.